feat: Allow overriding distribution package name #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a parameter to allow overriding the default distribution package name for installing NGINX from the OS repository.
- Introduces a pre-task in Molecule to set the package name for Alpine systems.
- Updates defaults documentation and changelog to reflect the new parameter.
- Adjusts the installation task to use the new parameter for package naming.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| molecule/distribution/converge.yml | Adds pre-task that sets the package name for Alpine but uses inconsistent variable names. |
| defaults/main/main.yml | Updates comments to document the new parameter for distribution package. |
| tasks/opensource/install-distribution.yml | Modifies the installation task to use the new parameter for package naming. |
| CHANGELOG.md | Adds an entry describing the new parameter feature. |
Comments suppressed due to low confidence (2)
molecule/distribution/converge.yml:7
- [nitpick] Consider renaming 'nginx_package_name' to 'nginx_distribution_package' to maintain consistency with the parameter name used in the defaults and installation tasks.
nginx_package_name: "@nginx:1.24/common"
molecule/distribution/converge.yml:15
- [nitpick] Replace 'nginx_distribution_name' with 'nginx_distribution_package' so that the variable name aligns with the new parameter and documentation.
nginx_distribution_name: "{{ nginx_package_name }}"
github-project-automation
bot
moved this to In progress
in NGINX Ansible roles & collection
alessfg
force-pushed
the
fix-distribution
branch
from
82cf7b5 to
4d2626c
Compare
github-project-automation
bot
moved this from In progress
to Done
in NGINX Ansible roles & collection
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a parameter,
nginx_distribution_package, to override the default NGINX package name when installing NGINX from your distribution/OS repository. Supersedes #857.Checklist
Before creating a PR, run through this checklist and mark each as complete:
defaults/main/*.yml,README.mdandCHANGELOG.md).